Editing NEWS-2.5.12

__NOTOC__
<!-- FIXME {{NEWS info 2.5}} -->
''This list is still in preparation; 2.5.12 has not yet been released.''

= WHAT'S CHANGED SINCE 2.5.11 =
<!-- up to 2019-11-20 (c482100c04) -->
2.5.12 is a bugfix release. It is expected to be the final release in the 2.5 series.

== Server / General ==

=== Changes affecting players (supplied rulesets) ===
* Vision-providing bases, such as buoys, could in some circumstances <em>remove</em> visibility from tiles, perhaps preventing the owner's cities from working them, in the presence of autosettlers. {{hrm|797698}} {{hrm|781551}}
* When a unit such as a Leader was cargo on a transport that was lost with its home city, it could be 'saved' by teleporting to the site of that city. This could leave an illegal stack of non-allied units on the same tile (Leader and city's conqueror), and prevent the Leader teleporting to a more distant, safe city. {{hrm|761808}}
* A few resources could be added to the map even when none were requested. {{hrm|763879}}
* Global warming and nuclear winter had a small chance of occurring even when the client displayed the chance as 0%. {{hrm|763882}}
* Cities produced pollution slightly too often. {{hrm|763881}}
* When gaining free Future Techs (for instance from Darwin's Voyage), some messages showed the wrong Future Tech number. {{hrm|761977}}
* Historians were never reporting on the "LARGEST Civilizations" (with the most citizens), by mistake. {{hrm|763883}}
* Historians failed to take angry citizens into account when reporting on the "HAPPIEST Civilizations". {{hrm|763884}}
* The end-game score for an arrived spaceship included population in habitation modules that weren't actually attached to the spaceship at launch. {{hrm|757442}}
* Fix a possible network protocol warning when units are starving. {{hrm|661865}}

=== Changes affecting other rulesets / modders ===
* In rulesets which allow capturing units, it's no longer allowed to capture a transport which is carrying units. (Previously this was allowed, but left the game in a broken state.) {{hrm|772516}}
* Fix longstanding bug in rulesets with 129 or more unit types; if any of the later units was an upgrade or conversion target, the client would not allow the action. {{hrm|763984}}
* In rulesets with nation-specific starting units, care is now taken to place them on tiles they can exist on, and clear any huts from their tile. {{hrm|767129}}
* Rulesets which defined a unit type without any <tt>tech_req</tt> could crash the server, rather than giving an error message. {{hrm|816374}}
* Rulesets which used <tt>default/nationlist.ruleset</tt> could not define a <tt>default_government</tt> outside the standard set defined by <tt>nationlist.ruleset</tt>. {{hrm|764299}}
* Fix inability to use <tt>default/nationlist.ruleset</tt> in a custom ruleset lacking standard plural-named terrains such as 'Hills'. {{hrm|827555}}
* Some improvements to unit debugging (<tt>/debug unit</tt>). {{hrm|760368}} {{hrm|760370}}
* Coding style clean up to supplied <tt>default.lua</tt> script. {{hrm|822189}}

<!-- === Changes affecting server operators === -->
<!-- === Low-level changes === -->
=== General ===
* Fix a rare compression failure which could stop communication between client and server. {{hrm|746878}} {{hrm|747319}}
* Slightly improved diagnostics for missing sound files. {{hrm|799291}}
* Tweak format of comments in various output files. {{hrm|761206}}
* Various internal changes which should only affect developers. {{hrm|767074}} {{hrm|800781}} {{hrm|801661}} {{hrm|848260}}

<!-- === AI === -->
== Clients ==
* When setting up single-player games, the client's AI level control no longer gets out of sync with the server state. {{hrm|765061}}
* In the city dialog, clicking on the middle tile to rearrange workers could fail to update the city dialog map display. {{hrm|736822}}
* ''(Gtk3)'' Happiness tooltips from the city dialog could appear in the wrong place. {{hrm|768105}}
* ''(SDL)'' Fix a possible crash on closing the client. {{hrm|824593}}

<!-- == Tools == -->
<!-- == Tilesets / Art == -->
== Help / Documentation ==
* Miscellaneous improvements to in-game text and user documentation. {{hrm|744655}} {{hrm|744672}} {{hrm|760366}}
* Miscellaneous changes to developer/ruleset docs. {{hrm|744666}} {{hrm|692480}} {{hrm|741552}}

== Translations ==
* Updated translations: British English, French, Catalan.
<!-- FIXME detailed stats -->

== Build/portability ==
* Fix building SDL client with Freetype &ge; 2.9.1. {{hrm|824994}}
* Fix Qt build issue on Cygwin. {{hrm|820604}}
* Fix some compiler warnings with GCC 8/9. {{hrm|765910}} {{hrm|801655}} {{hrm|830116}}
* Fix a warning with the wasm toolchain. {{hrm|829535}}
* Fix possible modpack installer build failure on some platforms. {{hrm|767468}}

See [[NEWS]] for older lists of changes.